Opened 11 years ago

Closed 10 years ago

Last modified 10 years ago

#3 closed enhancement (fixed)

Act on checkgroups control messages instead of sending mail

Reported by: eagle Owned by: eagle
Priority: low Milestone: 2.5.0
Component: utilities Version:
Severity: minor Keywords:
Cc:

Description

The only difference between doit and mail in control.ctl configuration of checkgroups handling is whether controlchan runs the checkgroups through docheckgroups to generate a shell script first. There's no way to tell the server to just make the necessary changes.

If this is added, there should probably be a corresponding configuration option telling controlchan the maximum number of changes that could be made at one time before bailing and mailing the changes to the admin.

Change History (3)

comment:1 Changed 11 years ago by Julien ÉLIE

Syntax like that should be used:

/maxdocheckgroups/:*:*:10
/maxdocheckgroups/:*:bad-one.*|bad-two.*:5
/maxdocheckgroups/:bad-sender@address:bad-one.*:2

/maxdosignedcheckgroups/:*:*:20
/maxdosignedcheckgroups/:*:bad-one.*|bad-two.*:5

comment:2 Changed 10 years ago by Julien ÉLIE

Resolution: fixed
Status: newclosed

(In [8431]) Many improvements to checkgroups handling:

  • Act on checkgroups control messages instead of sending mail;
  • Add the /maxdocheckgroups/ control.ctl option to specify the maximum number of changes that could be made at one time before bailing and mailing the changes to the admin;
  • Process all matching entries for a checkgroups and not the last matching control.ctl entry. It especially allows to use "drop" commands, combined with "mail" and "doit". To achieve that, controlchan uses exclusion and drop patterns;
  • Fix a long-standing bug causing patterns not being properly handled by docheckgroups: standard grep patterns were generated by controlchan instead of *egrep* patterns!
  • Fix a long-standing bug causing multiple entries for the same checkgroups sender not to be honoured (for instance aus.* and canb.*) because the last one did not match the list of newsgroups;
  • Fix two wrong log matches in innreport;
  • Documentation improvements, with useful samples.

close #3, #102

comment:3 Changed 10 years ago by Julien ÉLIE

Milestone: 2.5.0
Note: See TracTickets for help on using tickets.