Custom Query (44 matches)

Filters
 
Or
 
  
 
Columns

Show under each result:


Results (10 - 12 of 44)

1 2 3 4 5 6 7 8 9 10 11 12 13 14
Ticket Resolution Summary Owner Reporter
#41 fixed innreport creates incorrect file names at the start of the year eagle eagle
Description

Reported by Julien ÉLIE <julien@…>:

There is a problem in the name of the last report of the year. Instead of being named « news-notice.2006.12.31-04.15.02.html », it is named « news-notice.2006.01.01-00.00.00.html » and thus breaks everything in the html page (it is put at the bottom...).

And the line is « Jan 1 00:00:00 -- Dec 31 23:59:59 » instead of « Dec 31 04:15:02 -- Jan 2 04:15:03 ».

#121 fixed innfeed crashes after a failed assertion eagle Julien ÉLIE
Description

A long-standing issue in innfeed which sometimes crashes with:

2009-01-04 19:39:50 innfeed: assertion -- cxn != NULL -- failed in file connection.c line 1171
2009-01-04 20:59:43 innfeed: assertion -- cxn != NULL -- failed in file connection.c line 1171

It comes from cxnCheckstate() in connection.c, called only once in host.c. We should check whether the connection is still here. It may not have been affected during a for loop. For instance, we have:

    for (idx = 0 ; idx < host->maxConnections ; idx++)
      if (!host->cxnActive [idx] && !host->cxnSleeping [idx] &&
          (cxn = host->connections[idx]) != host->notThisCxn)

We could have a case where all the connections to a host are inactive and sleeping. Therefore, cxn will still be NULL and passed to cxnCheckstate().

Suggested patch:

Index: host.c
===================================================================
--- host.c      (révision 8263)
+++ host.c      (copie de travail)
@@ -1783,7 +1783,7 @@
       delArticle (extraRef) ;

       remArticle (article,&host->processed,&host->processedTail) ;
-      if (!cxnCheckstate (cxn))
+      if (cxn == NULL || !cxnCheckstate (cxn))
         {
           host->artsToTape++ ;
           host->gArtsToTape++ ;
#110 wontfix innd and nnrpd do not advertise IHAVE for the entire session eagle Julien ÉLIE
Description

According to RFC 3977, section 3.4.1:

Except as an effect of the MODE READER command (Section 5.3) on a mode-switching server, once a server advertises either or both of the IHAVE or READER capabilities, it MUST continue to advertise them for the entire session.

If IHAVE has been advertised, it will not necessarily be advertised for the entire session. innd and nnrpd only advertise the IHAVE capability when it is really available.

Impact: Probably none. It is sort of a weird edge case, since having such basic commands disappear after authentication is a little odd and would require an unusual configuration. It is probably not worth fixing. Besides, such a fix seems to partly defeat the point of the capability system.

1 2 3 4 5 6 7 8 9 10 11 12 13 14
Note: See TracQuery for help on using queries.