Custom Query (44 matches)

controlchan should be able to properly decode newgroup control articles which contain an application/news-groupinfo entity. It is a new structure for such articles described in USEPRO.

A long-standing issue in innfeed which sometimes crashes with:

2009-01-04 19:39:50 innfeed: assertion -- cxn != NULL -- failed in file connection.c line 1171
2009-01-04 20:59:43 innfeed: assertion -- cxn != NULL -- failed in file connection.c line 1171

It comes from cxnCheckstate() in connection.c, called only once in host.c. We should check whether the connection is still here. It may not have been affected during a for loop. For instance, we have:

    for (idx = 0 ; idx < host->maxConnections ; idx++)
      if (!host->cxnActive [idx] && !host->cxnSleeping [idx] &&
          (cxn = host->connections[idx]) != host->notThisCxn)

We could have a case where all the connections to a host are inactive and sleeping. Therefore, cxn will still be NULL and passed to cxnCheckstate().

Suggested patch:

Index: host.c
===================================================================
--- host.c      (révision 8263)
+++ host.c      (copie de travail)
@@ -1783,7 +1783,7 @@
       delArticle (extraRef) ;

       remArticle (article,&host->processed,&host->processedTail) ;
-      if (!cxnCheckstate (cxn))
+      if (cxn == NULL || !cxnCheckstate (cxn))
         {
           host->artsToTape++ ;
           host->gArtsToTape++ ;

INN recognizes LIST keywords not mentioned in CAPABILITIES. They should be documented in an Internet-Draft.

• LIST DISTRIBUTIONS
• LIST MODERATORS
• LIST MOTD
• LIST SUBSCRIPTIONS (with a wildmat)

• Define the meaning of some other status fields of LIST ACTIVE:
  • j No posting allowed, incoming articles filed into junk
  • x No posting allowed, remote postings rejected
  • =* Group aliasing

The meaning of a junk newsgroup will have to be described.

How could we advertise these new status fields? (EXTENDED-STATUS, with a version number, as a new capability?)

Available references:

​http://www.eyrie.org/~eagle/nntp/drafts/draft-hernacki-nntplist-02.txt ​http://www.eyrie.org/~eagle/nntp/rfcs/rfc2980.txt