Custom Query (44 matches)

A long-standing issue in innfeed which sometimes crashes with:

2009-01-04 19:39:50 innfeed: assertion -- cxn != NULL -- failed in file connection.c line 1171
2009-01-04 20:59:43 innfeed: assertion -- cxn != NULL -- failed in file connection.c line 1171

It comes from cxnCheckstate() in connection.c, called only once in host.c. We should check whether the connection is still here. It may not have been affected during a for loop. For instance, we have:

    for (idx = 0 ; idx < host->maxConnections ; idx++)
      if (!host->cxnActive [idx] && !host->cxnSleeping [idx] &&
          (cxn = host->connections[idx]) != host->notThisCxn)

We could have a case where all the connections to a host are inactive and sleeping. Therefore, cxn will still be NULL and passed to cxnCheckstate().

Suggested patch:

Index: host.c
===================================================================
--- host.c      (révision 8263)
+++ host.c      (copie de travail)
@@ -1783,7 +1783,7 @@
       delArticle (extraRef) ;

       remArticle (article,&host->processed,&host->processedTail) ;
-      if (!cxnCheckstate (cxn))
+      if (cxn == NULL || !cxnCheckstate (cxn))
         {
           host->artsToTape++ ;
           host->gArtsToTape++ ;

controlchan should be able to properly decode newgroup control articles which contain an application/news-groupinfo entity. It is a new structure for such articles described in USEPRO.

In getopts.pl, we can read:

# This library is no longer being maintained, and is included for backward compatibility with Perl 4 programs which may require it.

Moreover, it causes problems like:

% innmail -h

• Use of uninitialized value in string eq at /usr/lib/perl5/5.8.5/getopts.pl line 26.

getopts.pl:

    if($pos >= $[) {
        if($args[$pos+1] eq ':') {   ### <--- Line 26
            shift(@ARGV);

% innmail -s "test" mail-address

• Use of uninitialized value in string eq at (eval 139) line 3.

We should use Getopt::Std instead of getopts.pl.